Skip to content

chore: bump github.com/gorilla/websocket from 1.4.3-0.20220104015952-9111bb834a68 to 1.5.0 - #14

Closed
dependabot[bot] wants to merge 2 commits into
masterfrom
dependabot/go_modules/github.com/gorilla/websocket-1.5.0
Closed

chore: bump github.com/gorilla/websocket from 1.4.3-0.20220104015952-9111bb834a68 to 1.5.0#14
dependabot[bot] wants to merge 2 commits into
masterfrom
dependabot/go_modules/github.com/gorilla/websocket-1.5.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Mar 6, 2023

Copy link
Copy Markdown

Bumps github.com/gorilla/websocket from 1.4.3-0.20220104015952-9111bb834a68 to 1.5.0.

Release notes

Sourced from github.com/gorilla/websocket's releases.

Minor new features and maintenance update

CHANGELOG

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

pasinskim and others added 2 commits March 3, 2023 12:39
And fix some missing links.

Changelog: None

Signed-off-by: Marcin Pasinski <marcin.pasinski@northern.tech>
Bumps [github.com/gorilla/websocket](https://github.com/gorilla/websocket) from 1.4.3-0.20220104015952-9111bb834a68 to 1.5.0.
- [Release notes](https://github.com/gorilla/websocket/releases)
- [Commits](https://github.com/gorilla/websocket/commits/v1.5.0)

---
updated-dependencies:
- dependency-name: github.com/gorilla/websocket
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Mar 6, 2023
@dependabot @github

dependabot Bot commented on behalf of github Jul 8, 2024

Copy link
Copy Markdown
Author

Superseded by #32.

@dependabot dependabot Bot closed this Jul 8, 2024
@dependabot
dependabot Bot deleted the dependabot/go_modules/github.com/gorilla/websocket-1.5.0 branch July 8, 2024 22:25
pasinskim pushed a commit that referenced this pull request Jun 23, 2025
Once in a while, in release mode only, this test will display this
symptom:

```
...
record_id=163 severity=trace time="2023-Oct-03 16:22:53.911616" name="http_client" url="http://127.0.0.1:8001" msg="Read 16384 bytes of body data from stream."
record_id=164 severity=trace time="2023-Oct-03 16:22:53.911802" name="http_client" url="http://127.0.0.1:8001" msg="Read 16384 bytes of body data from stream."
record_id=165 severity=warning time="2023-Oct-03 16:22:53.912043" name="http_client" url="http://127.0.0.1:8001" msg="Client destroyed while request is still active!"
[       OK ] HttpTest.TestResponseBody (202 ms)
[----------] 1 test from HttpTest (202 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (202 ms total)
[  PASSED  ] 1 test.
corrupted double-linked list
Aborted (core dumped)
```

The backtrace reveals that it happens at the very very end, when exit
handlers are called:

```
 Program terminated with signal SIGABRT, Aborted.
 #0  __pthread_kill_implementation (no_tid=0, signo=6, threadid=139805181667136)
     at ./nptl/pthread_kill.c:44
 44	./nptl/pthread_kill.c: No such file or directory.
 (gdb) bt
 #0  __pthread_kill_implementation (no_tid=0, signo=6, threadid=139805181667136)
     at ./nptl/pthread_kill.c:44
 #1  __pthread_kill_internal (signo=6, threadid=139805181667136)
     at ./nptl/pthread_kill.c:78
 #2  __GI___pthread_kill (threadid=139805181667136, signo=signo@entry=6)
     at ./nptl/pthread_kill.c:89
 #3  0x00007f26ee375476 in __GI_raise (sig=sig@entry=6)
     at ../sysdeps/posix/raise.c:26
 #4  0x00007f26ee35b7f3 in __GI_abort () at ./stdlib/abort.c:79
 #5  0x00007f26ee3bc6f6 in __libc_message (action=action@entry=do_abort,
     fmt=fmt@entry=0x7f26ee50eb8c "%s\n") at ../sysdeps/posix/libc_fatal.c:155
 #6  0x00007f26ee3d3d7c in malloc_printerr (
     str=str@entry=0x7f26ee50c72e "corrupted double-linked list")
     at ./malloc/malloc.c:5664
 #7  0x00007f26ee3d484c in unlink_chunk (p=<optimized out>,
     av=0x7f26ee54cc80 <main_arena>) at ./malloc/malloc.c:1635
 #8  0x00007f26ee3d49e9 in malloc_consolidate (
     av=av@entry=0x7f26ee54cc80 <main_arena>) at ./malloc/malloc.c:4780
 #9  0x00007f26ee3d5f20 in _int_free (av=0x7f26ee54cc80 <main_arena>,
     p=0x561b9a7adae0, have_lock=<optimized out>) at ./malloc/malloc.c:4674
 #10 0x00007f26ee3d84d3 in __GI___libc_free (mem=<optimized out>)
     at ./malloc/malloc.c:3391
 #11 0x00007f26eeb2017d in ?? () from /lib/x86_64-linux-gnu/libcrypto.so.3
 #12 0x00007f26eeb44d0d in ?? () from /lib/x86_64-linux-gnu/libcrypto.so.3
 #13 0x00007f26eeb1b1d5 in CRYPTO_free_ex_data ()
    from /lib/x86_64-linux-gnu/libcrypto.so.3
 #14 0x00007f26eeb13d1f in ?? () from /lib/x86_64-linux-gnu/libcrypto.so.3
 #15 0x00007f26eeb1d929 in OPENSSL_cleanup ()
    from /lib/x86_64-linux-gnu/libcrypto.so.3
 #16 0x00007f26ee378495 in __run_exit_handlers (status=0,
     listp=0x7f26ee54c838 <__exit_funcs>,
     run_list_atexit=run_list_atexit@entry=true, run_dtors=run_dtors@entry=true)
     at ./stdlib/exit.c:113
 #17 0x00007f26ee378610 in __GI_exit (status=<optimized out>)
     at ./stdlib/exit.c:143
 #18 0x00007f26ee35cd97 in __libc_start_call_main (
     main=main@entry=0x561b9a0c0f70 <main(int, char**)>, argc=argc@entry=2,
     argv=argv@entry=0x7ffe48d637c8)
     at ../sysdeps/nptl/libc_start_call_main.h:74
 #19 0x00007f26ee35ce40 in __libc_start_main_impl (
     main=0x561b9a0c0f70 <main(int, char**)>, argc=2, argv=0x7ffe48d637c8,
     init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>,
     stack_end=0x7ffe48d637b8) at ../csu/libc-start.c:392
 #20 0x0000561b9a0c1a35 in _start ()
```

It is unknown what causes the corruption, and the problem only happens
in release mode with sanitizers disabled, so it's very hard to
investigate. But although the root cause isn't known, it's believed to
happen when the body has not been completely consumed, and the program
exits. Since this "don't-consume -> then exit" scenario is very
unlikely in production, work around it by making sure both handlers
have run before exiting, instead of only one of them. I tested this
for hundreds of runs, and it worked. Previously it would fail every
15-30 runs or so.

This also has the added benefit of not accidentally skipping the test
conditionals inside the body handler.

Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant